fix: Check for null or empty class name in generate OpenAPI annotations #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gooderham <[email protected]>
|
|
Good catch! I have never seen that PsiClass.getQualifiedName() could return null. It is very annoying. I merge your PR, but we need to check withthis problem with null in other code location https://github.com/search?q=repo%3Aredhat-developer%2Fintellij-quarkus%20getQualifiedName&type=code |
|
Thanks @turkeylurkey ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MicroProfileGenerateOpenAPIOperation we call
PsiClass.getQualifiedName()which is nullable. It returns null when the class is local or a type parameter. In our test case we used a type parameter so we see the need to check the return type.Fixes #1397