Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow hotswap in 'runIde' for >=IC-2024.1 #951

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Dec 9, 2024

This allows hot code swap when developing.

Without the change:

Steps:

  1. EXEC: add a line (ex. System.err.println("hello") in RefreshAction#doActionPerformed
    public void doActionPerformed(ApplicationsRootNode root) {
System.err.println("hello");
        if (root == null) {
          return;
        }
  1. ASSERT: In the editor, you are informed that you can hot-swap the code
  1. EXEC: click the bug icon to the right of the notification

Result:
Hot swap fails

With the change:

Steps:

  1. EXEC: change the line that you added aboveRefreshAction#doActionPerformed
  2. ASSERT: In the editor, you are informed that you can hot-swap the code
    <img src=https://github.com/user-attachments/assets/216a545c-4066-4e4f-be11-f760a4d90333 width)=400/>
  3. EXEC: click the bug icon to the right of the notification

Result:
Hot swap succeeds

@adietish adietish changed the title allow hotswap in 'runIde' for >=IC-2024.1 feat: allow hotswap in 'runIde' for >=IC-2024.1 Dec 9, 2024
@adietish adietish self-assigned this Dec 9, 2024
Copy link

sonarqubecloud bot commented Dec 9, 2024

@adietish adietish added the enhancement New feature or request label Dec 11, 2024
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor Author

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Dec 13, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

/override "Aggregated Test Report" "Integration UI Tests with Local Kind Cluster Context Report" "Integration UI Tests with No Context Report"

Copy link

openshift-ci bot commented Dec 13, 2024

@adietish: Overrode contexts on behalf of adietish: Aggregated Test Report, Integration UI Tests with Local Kind Cluster Context Report, Integration UI Tests with No Context Report

In response to this:

/override "Aggregated Test Report" "Integration UI Tests with Local Kind Cluster Context Report" "Integration UI Tests with No Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit dc979a2 into redhat-developer:main Dec 13, 2024
26 of 27 checks passed
@adietish adietish deleted the allow_hotswap branch December 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved enhancement New feature or request lgtm
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants