-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow hotswap in 'runIde' for >=IC-2024.1 #951
feat: allow hotswap in 'runIde' for >=IC-2024.1 #951
Conversation
8cf3bbe
to
08d2457
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
08d2457
to
e8cc20e
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-openshift |
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Aggregated Test Report" "Integration UI Tests with Local Kind Cluster Context Report" "Integration UI Tests with No Context Report" |
@adietish: Overrode contexts on behalf of adietish: Aggregated Test Report, Integration UI Tests with Local Kind Cluster Context Report, Integration UI Tests with No Context Report In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dc979a2
into
redhat-developer:main
This allows hot code swap when developing.
Without the change:
Steps:
System.err.println("hello")
inRefreshAction#doActionPerformed
Result:
Hot swap fails
With the change:
Steps:
RefreshAction#doActionPerformed
<img src=https://github.com/user-attachments/assets/216a545c-4066-4e4f-be11-f760a4d90333 width)=400/>
Result:
Hot swap succeeds