fix: replaced helm png by svg, use resized, not scaled icon (#874)

[adietish]

fixes #874

[adietish]

@sbouchet:
The icon used here has a size of 32x32. When using it for the tree node, it gets scaled to 16x16.
Text and Icons are provided to a node in a so called "Presentation". When a node is selected, the presentation is updated. Weird enough, this updated presentation is using the unscaled/original size of the icon (not the scaled version that it was given when the node was created).
I thus provide 2 different svg icons (replacing the original png): a 32x32 variant and a 16x16 variant. The 16x16 variant is to be used in the tree, the 32x32 is to be used in the helm charts dialog.
Please review. Thx.

[sbouchet]

there is still a wrong size for installed charts, when selected :

[adietish]

@sbouchet: I suspect that this is caused by a bug in the IDEA platform: we were using "scaled" icons (32px original size, scaled to 16px in the tree, unscaled 32px in the charts dialog). We do this using SwingUtils#scaleIcon. A scaled icon keeps its original size but indicates a scaled "display" size (I tracked things down to the tree cell renderer where it paints a selected node). The tree cell renderer is using the scaled display size when rendering a non-selected tree node, but is using the original size when rendering a selected node. There's no such problem when using an new icon with the corrected size using IconUtil#resizeSquared.

[adietish]

@sbouchet: please re-review

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[adietish]

/override ci/prow/e2e-openshift

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbouchet]

tested against new UI and Old UI, everything is correct !

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbouchet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adietish]

/override "Aggregated Test Report"

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: Aggregated Test Report

In response to this:

/override "Aggregated Test Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adietish]

/override "Cluster Integration UI Tests Report"

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: Cluster Integration UI Tests Report

In response to this:

/override "Cluster Integration UI Tests Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adietish]

/override "Public Integration UI Tests Report"

[openshift-ci]

@adietish: Overrode contexts on behalf of adietish: Public Integration UI Tests Report

In response to this:

/override "Public Integration UI Tests Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.