-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a unit test when podman is not present #886
test: add a unit test when podman is not present #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a few nitpicks. Other than that things look good to me.
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliComponentTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliComponentTest.java
Outdated
Show resolved
Hide resolved
src/it/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCliComponentTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Quality Gate passedIssues Measures |
/override ci/prow/e2e-openshift |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adietish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-openshift |
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sbouchet: I dont understand what's wrong with the |
it means the Cluster Integration UI Tests runs failed. |
8232bf8
into
redhat-developer:main
What is the purpose of this change? What does it change?
Was the change discussed in an issue?
fixes #782
How to test changes?