Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a unit test when podman is not present #886

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

sbouchet
Copy link
Collaborator

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #782

How to test changes?

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a few nitpicks. Other than that things look good to me.

Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
Copy link

sonarqubecloud bot commented Aug 8, 2024

@sbouchet
Copy link
Collaborator Author

sbouchet commented Aug 9, 2024

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Aug 9, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbouchet sbouchet requested a review from adietish September 20, 2024 08:33
Copy link

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2024
Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Sep 23, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor

@sbouchet: I dont understand what's wrong with the Conventional Commits PR Check / Cluster Integration UI Tests Report (pull_request_target)

@sbouchet
Copy link
Collaborator Author

@sbouchet: I dont understand what's wrong with the Conventional Commits PR Check / Cluster Integration UI Tests Report (pull_request_target)

it means the Cluster Integration UI Tests runs failed.

@openshift-merge-bot openshift-merge-bot bot merged commit 8232bf8 into redhat-developer:main Sep 23, 2024
18 checks passed
@sbouchet sbouchet deleted the issue-782 branch September 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a unit test in DevOnPodmanComponentActionTest
2 participants