Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse login command regexp and other regexp #884

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

sbouchet
Copy link
Collaborator

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #871

How to test changes?

@sbouchet sbouchet requested a review from adietish July 25, 2024 11:20
Copy link

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works for me

Copy link

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Jul 26, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d92992d into redhat-developer:main Jul 26, 2024
16 checks passed
@sbouchet sbouchet deleted the issue-871 branch July 26, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste login command for username/password parses password incorrectly
2 participants