Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix usage of deprecated APIs #879

Merged

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Jul 18, 2024

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes (partially) #732

How to test changes?

Signed-off-by: Stephane Bouchet <[email protected]>
@openshift-ci openshift-ci bot requested a review from adietish July 18, 2024 10:25
@sbouchet sbouchet added this to the 1.11.0 milestone Jul 18, 2024
@sbouchet sbouchet added the task label Jul 18, 2024
Copy link

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adietish
Copy link
Contributor

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Jul 18, 2024

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

return result;
}

public DebugStatus parseDebugStatus() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaics this method was never used and could therefore be eliminated +1. Afaiu this has the benefit that apache commons is not used any more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm looking into other places that still uses apache Stringutils class

@openshift-merge-bot openshift-merge-bot bot merged commit 5dd1d17 into redhat-developer:main Jul 18, 2024
17 checks passed
@sbouchet sbouchet deleted the fix_deprecated_API branch July 18, 2024 13:55
@sbouchet sbouchet self-assigned this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants