fix: Anonymise error messages by removing exception handling #856
Conversation
sbouchet
changed the title
|
/hold |
There was a problem hiding this comment.
Wondering why things are not anonymized. I see your error being sent to com.redhat.devtools.intellij.telemetry.core.service.Message.error(message) which is as follows:
public T error(String message) {
this.property("error", AnonymizeUtils.anonymize(message));What am I missing?
the AnonymizeUtils class does not handle the cases specific to openshift, like cluster URL and token. see TelemetrySender class |
|
/unhold |
|
was holding while preparing 1.10.0. release. un holding since fix i likely to take some time to implement |
|
/override ci/prow/e2e-openshift |
|
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-openshift |
|
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-openshift |
|
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-openshift |
|
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
|
/unhold |
Signed-off-by: Stephane Bouchet <[email protected]>
|
|
@sbouchet: can you please rebase this so that we can merge it? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adietish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-openshift |
|
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 36d7126
into
redhat-developer:main
What is the purpose of this change? What does it change?
Was the change discussed in an issue?
fixes #855
How to test changes?