Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update helm to 3.14.4 #851

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix: Update helm to 3.14.4 #851

merged 1 commit into from
Jun 28, 2024

Conversation

sbouchet
Copy link
Collaborator

@openshift-ci openshift-ci bot requested a review from adietish June 25, 2024 04:04
Copy link

@sbouchet sbouchet mentioned this pull request Jun 25, 2024
@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Jun 25, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbouchet sbouchet added the dependencies Pull requests that update a dependency file label Jun 26, 2024
@sbouchet sbouchet added this to the 1.10.0 milestone Jun 26, 2024
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Downloaded all binaries, checksum'ed them and tested it on MacOS while removing my 3.13 helm binary beforehand. Works for me.

Copy link

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Jun 28, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5f00221 into main Jun 28, 2024
17 checks passed
@adietish adietish deleted the helm-3.14.4 branch June 28, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file lgtm
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants