Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix telemetry extension report #843

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: fix telemetry extension report #843

merged 2 commits into from
Aug 7, 2024

Conversation

sbouchet
Copy link
Collaborator

@sbouchet sbouchet commented Jun 18, 2024 •
edited
Loading

What is the purpose of this change? What does it change?

use fix implemented in telemetry redhat-developer/intellij-redhat-telemetry#86

Was the change discussed in an issue?

fixes #824, #847

How to test changes?

@sbouchet sbouchet requested a review from adietish June 18, 2024 15:45
@sbouchet sbouchet marked this pull request as draft June 19, 2024 08:06
@sbouchet sbouchet force-pushed the issue-824 branch 3 times, most recently from c436743 to 18b4d5e Compare July 12, 2024 14:28
@sbouchet sbouchet force-pushed the issue-824 branch 2 times, most recently from ff362b1 to d8435e8 Compare July 22, 2024 09:27
@sbouchet sbouchet marked this pull request as ready for review July 22, 2024 09:29
@sbouchet sbouchet linked an issue Jul 22, 2024 that may be closed by this pull request
Use Telemetry which supports limitations (tentatively 1.2.0) #847
Closed
sbouchet added 2 commits August 2, 2024 15:52
@sbouchet
fix telemetry extension name
40ec649 
Signed-off-by: Stephane Bouchet <[email protected]>
@sbouchet
fix telemetry extension name
a9ebf5f 
Signed-off-by: Stephane Bouchet <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adietish
adietish approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2024
@adietish adietish assigned sbouchet and unassigned adietish Aug 7, 2024
@sbouchet
Copy link
Collaborator Author

sbouchet commented Aug 7, 2024

/override ci/prow/e2e-openshift

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 7, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9d1e9ee into redhat-developer:main Aug 7, 2024
16 checks passed
@sbouchet sbouchet deleted the issue-824 branch August 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adietish adietish adietish approved these changes

Assignees

@sbouchet sbouchet

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
3 participants
@sbouchet @adietish @openshift-merge-robot