Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Integration tests #805

Merged

Conversation

sbouchet
Copy link
Collaborator

What is the purpose of this change? What does it change?

current main integration tests are failing.

Was the change discussed in an issue?

How to test changes?

Signed-off-by: Stephane Bouchet <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sbouchet sbouchet added this to the 1.10.0 milestone Apr 24, 2024
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With all the reformatting it is hard for me to spot what exactly fixes the ITs. Can you please point out?

Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbouchet
Copy link
Collaborator Author

LGTM. With all the reformatting it is hard for me to spot what exactly fixes the ITs. Can you please point out?

well, it's only the usage of a new test project, from springboot to nodejs.
i also added a devfile 2.2.0 along with the old 2.0.0 as separate unit test for regression.

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Apr 24, 2024

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9306b26 into redhat-developer:main Apr 24, 2024
18 checks passed
@sbouchet sbouchet deleted the fix-integration-tests branch April 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants