Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor: use ClusterHelper#isOpenShift in commons #628

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

adietish
Copy link
Contributor

@openshift-ci openshift-ci bot requested a review from sbouchet November 30, 2023 18:42
@adietish adietish self-assigned this Nov 30, 2023
@adietish adietish changed the title use ClusterHelper#isOpenShift in commons refactor: use ClusterHelper#isOpenShift in commons Nov 30, 2023
@adietish adietish force-pushed the use_isOpenShift_in_commons branch from 9592a66 to 3a98ac7 Compare November 30, 2023 20:20
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 1, 2023
@sbouchet
Copy link
Collaborator

sbouchet commented Dec 1, 2023

/hold

@openshift-ci openshift-ci bot removed the lgtm label Dec 4, 2023
Copy link

openshift-ci bot commented Dec 4, 2023

New changes are detected. LGTM label has been removed.

@adietish adietish changed the title refactor: use ClusterHelper#isOpenShift in commons fix: refactor: use ClusterHelper#isOpenShift in commons Dec 4, 2023
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sbouchet
Copy link
Collaborator

sbouchet commented Dec 4, 2023

/unhold

@adietish
Copy link
Contributor Author

adietish commented Dec 4, 2023

/override ci/prow/e2e-openshift

Copy link

openshift-ci bot commented Dec 4, 2023

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish
Copy link
Contributor Author

adietish commented Dec 4, 2023

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Dec 4, 2023

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adietish adietish merged commit 3423f84 into redhat-developer:main Dec 5, 2023
15 of 17 checks passed
@adietish adietish deleted the use_isOpenShift_in_commons branch December 5, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants