-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can't connect to a cluster with private certificate #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other my suggestion for an improvement +1, LGTM
src/main/java/org/jboss/tools/intellij/openshift/utils/odo/OdoCli.java
Outdated
Show resolved
Hide resolved
/override ci/prow/e2e-4.11 |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
fix test Signed-off-by: Stephane Bouchet <[email protected]>
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/override ci/prow/e2e-4.11 |
@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it with the latest cluster set up by our group in "forum-ui-clusters" at https://api.akundu-XXXXXX.devcluster.openshift.com:6443/. In cmd-line this cluster can only be connected to by using the --insecure-skip-tls-verify
flag (which then adds the above property to the kubeconfig). Could connect to it using intellij-openshift-connector and install helm chart to it.
LGTM
/approve |
What is the purpose of this change? What does it change?
Openshift view can't list / createcompoennts on clusters using private certificates.
Was the change discussed in an issue?
fixes #547
How to test changes?
follow redhat-developer/intellij-kubernetes#600 (comment) to set up a cluster with private certificate ( CRC ), then please also modify the kubeconfig file to something like
without this manual change, odo can't access the cluster.