Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't connect to a cluster with private certificate #599

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

sbouchet
Copy link
Collaborator

What is the purpose of this change? What does it change?

Openshift view can't list / createcompoennts on clusters using private certificates.

Was the change discussed in an issue?

fixes #547

How to test changes?

follow redhat-developer/intellij-kubernetes#600 (comment) to set up a cluster with private certificate ( CRC ), then please also modify the kubeconfig file to something like

- cluster:
    insecure-skip-tls-verify: true
    server: "https://api.crc.testing:6443"
  name: "api-crc-testing:6443"

without this manual change, odo can't access the cluster.

@sbouchet sbouchet requested a review from adietish October 18, 2023 14:38
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other my suggestion for an improvement +1, LGTM

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 10, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Stephane Bouchet <[email protected]>
fix test

Signed-off-by: Stephane Bouchet <[email protected]>
Copy link

sonarqubecloud bot commented Nov 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sbouchet
Copy link
Collaborator Author

/override ci/prow/e2e-4.11

Copy link

openshift-ci bot commented Nov 20, 2023

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-4.11

In response to this:

/override ci/prow/e2e-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbouchet sbouchet requested a review from adietish November 20, 2023 18:18
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it with the latest cluster set up by our group in "forum-ui-clusters" at https://api.akundu-XXXXXX.devcluster.openshift.com:6443/. In cmd-line this cluster can only be connected to by using the --insecure-skip-tls-verify flag (which then adds the above property to the kubeconfig). Could connect to it using intellij-openshift-connector and install helm chart to it.
LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 22, 2023
@sbouchet
Copy link
Collaborator Author

/approve

@sbouchet sbouchet merged commit f9de414 into redhat-developer:main Nov 22, 2023
13 of 15 checks passed
@sbouchet sbouchet deleted the issue-547 branch November 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants