Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont create unneed disposable (#798) #799

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix: dont create unneed disposable (#798) #799

merged 2 commits into from
Oct 10, 2024

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Oct 9, 2024

fixes #798

@adietish adietish self-assigned this Oct 9, 2024
@adietish adietish requested a review from sbouchet October 9, 2024 11:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sbouchet
sbouchet approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 0d2a743 into redhat-developer:main Oct 10, 2024
13 checks passed
@adietish adietish deleted the issue-798 branch October 10, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adietish @sbouchet