Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use IDEAManager in intellij-common (#718) #731

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Mar 22, 2024

@adietish adietish self-assigned this Mar 22, 2024
@adietish adietish force-pushed the issue-718 branch 2 times, most recently from a3cbc0e to d75e859 Compare March 22, 2024 17:42
@adietish adietish marked this pull request as draft March 22, 2024 17:43
@adietish
Copy link
Collaborator Author

it's odd: it compiles but IDEA is not prompting for the unknown certificate to be accepted any more.

@adietish
Copy link
Collaborator Author

I fixed IDEATrustManager in intellij-common in redhat-developer/intellij-common#213. Once this PR is merged we can merge here.

@adietish adietish marked this pull request as ready for review April 8, 2024 13:15
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adietish
Copy link
Collaborator Author

adietish commented Apr 8, 2024

@sbouchet: please review

Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit bfd0eca into redhat-developer:main Apr 9, 2024
14 checks passed
@adietish adietish deleted the issue-718 branch April 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Use IDEATrustManager class from common
2 participants