Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ClusterHelper#isOpenShift in intellij-common #674

Merged
merged 1 commit into from
Dec 4, 2023
Merged

use ClusterHelper#isOpenShift in intellij-common #674

merged 1 commit into from
Dec 4, 2023

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Nov 30, 2023 •
edited
Loading

@adietish adietish changed the title use ClientHelper#isOpenShift in intellij-common use ClusterHelper#isOpenShift in intellij-common Nov 30, 2023
@adietish adietish force-pushed the use_ClusterHelper#isOpenShift branch from 0f99496 to 8ce1c30 Compare November 30, 2023 19:35
@adietish adietish requested a review from sbouchet November 30, 2023 19:36
@adietish adietish self-assigned this Nov 30, 2023
@adietish adietish force-pushed the use_ClusterHelper#isOpenShift branch from 8ce1c30 to ce67aa3 Compare December 1, 2023 15:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adietish adietish requested a review from sbouchet December 1, 2023 15:06
sbouchet
sbouchet approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adietish adietish merged commit 2ff9243 into redhat-developer:main Dec 4, 2023
16 checks passed
@adietish adietish deleted the use_ClusterHelper#isOpenShift branch December 4, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
IDE Cloudaptors
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adietish @sbouchet