support multiple resources in the editor (#549)

[adietish]

fixes #549

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[adietish]

@sbouchet, @robstryker. @jeffmaury: Please test this PR. Thanks!

I wrote down 3 scenarios.
Feel free to whatever you want and try to trash the editor :)
Further down there's a yaml document with 5 resources: 2 pods, 2 services, 1 ingress. You can edit this document in the editor and push it to the cluster. It should create the resources.
Pull notifications are not supported in multi-resource mode. You should only get notified if you can push something (in case you modified the document or the resource was deleted on the cluster).

Scenarios

Create resources

1. EXEC: open new editor via File > New > YML file
2. EXEC: paste one of the documents that you find below
3. ASSERT: Push notification appears
4. EXEC: hit Push

Expected Result:

1. ASSERT: in tree: new pods "banana-app", "apple-app" appear in [context] > Workloads > Pods
2. ASSERT: in the tree: new services "banana-service", "apple-service" appear in [context] > Nework > Services
3. ASSERT: in the tree: new Ingress "example-ingress" appear in [context] > Nework > Ingress

Update resources

1. ASSERT: Have resources created as in test before
2. EXEC: in the editor go to apple-service, metadata. Add a label:

metadata:
  name: apple-service
  labels:
    smurf: grumpy

3. ASSERT: Push notification appears "update 'apple-service'"
4. EXEC: hit "Push" in notification

Expected Result:
Updated notification is displayed "updated 'apple-service' appears"

Delete and Recreate

1. ASSERT: Have resources created as in test before
2. EXEC: in tree: go Workloads > Services > apple-service & delete it
3. ASSERT: editor shows "Push" notification "create apple-service"
4. EXEC: hit "Push"

Expected Result:
in tree: Workloads > Services > apple-service appears

Multi-resource document (2 pods, 2 service, 1 ingress)

kind: Pod
apiVersion: v1
metadata:
  name: apple-app
  labels:
    app: apple
spec:
  containers:
    - name: apple-app
      image: hashicorp/http-echo
      args:
        - "-text=apple"
---
kind: Service
apiVersion: v1
metadata:
  name: apple-service
spec:
  selector:
    app: apple 
  ports:
    - port: 5678 # Default port for image
---
kind: Pod
apiVersion: v1
metadata:
  name: banana-app
  labels:
    app: banana
spec:
  containers:
    - name: banana-app
      image: hashicorp/http-echo
      args:
        - "-text=banana"
---
kind: Service
apiVersion: v1
metadata:
  name: banana-service
spec:
  selector:
    app: banana
  ports:
    - port: 5678 # Default port for image
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: example-ingress
  annotations:
    ingress.kubernetes.io/rewrite-target: /
spec:
  rules:
    - http:
        paths:
          - pathType: Exact
            path: /apple
            backend:
              service:
                name: apple-service
                port:
                  number: 5678
          - pathType: Exact
            path: /banana
            backend:
              service:
                name: banana-service
                port:
                  number: 5678

[jeffmaury]

Tried but once all resources have been created, I modified one and was asked for Push and got an error as a result.

[adietish]

@jeffmaury

I modified one and was asked for Push and got an error as a result.

Thanks for spotting this, I could replicate it. It is not related to the support for multiple resources in an editor, it also happens when you edit a pod in his very own editor. This does not happen for me when I add a label to one of the services.
I'll thus takle this in a separate issue: #561

This error seems related to the spec object in the pod. The error complains about prohibited changes in spec. Adding a label in one of the Services (which do not have a spec) works fine.
Interestingly kubectl apply works here. Digging into this I found longs threads in the kubernetes-client where differences in their #createOrReplace method and kubectls apply were discussed.

[jeffmaury]

LGTM

[sbouchet]

Played around to create/modify/delete resources on minikube. LGTM