Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option "Show directory for non-unique file names" stops working #652

Closed
afolgado opened this issue Aug 18, 2023 · 3 comments · Fixed by #657
Closed

Option "Show directory for non-unique file names" stops working #652

afolgado opened this issue Aug 18, 2023 · 3 comments · Fixed by #657
Assignees
Labels
kind/bug Something isn't working severity/major
Milestone

Comments

@afolgado
Copy link

As soon as this plugin is enabled in IntelliJ, the option "Show directory for non-unique file names" in Editor->General->Editor Tabs stops working.

Tested in IntelliJ Ultimate 2023.1.x and 2023.2.

@adietish adietish self-assigned this Sep 4, 2023
@adietish
Copy link
Collaborator

adietish commented Sep 4, 2023

@afolgado thanks for posting this. I'll look into it and keep you posted.

@adietish
Copy link
Collaborator

adietish commented Sep 4, 2023

I can reproduce this:

Steps:

  1. ASSERT: have IDE running without our plugin (disabling also works)
  2. ASSERT: have 2 yaml files with the same name in 2 different locations in your project:
  • /test.yml
  • /src/main/resources/test.yml
  1. EXEC: open both files in editors

Result:
Title of the editor that edits file /test.yml is file.yml. The 2nd editor displays /src/main/resources/test.yml in the title

Steps:

  1. ASSERT: have intellij-kubernetes installed/enabled
  2. EXEC: open both files

Result:
Title of the editor that edits file /test.yml is file.yml. The 2nd editor displays test.yml in the title. The settings option Editor->General->Editor does NOT work any more!

@adietish adietish added kind/bug Something isn't working severity/major labels Sep 4, 2023
@adietish adietish added this to the 1.2.0 milestone Sep 4, 2023
@adietish adietish moved this to 🏗 In progress in IDE Cloudaptors Sep 4, 2023
@adietish
Copy link
Collaborator

adietish commented Sep 4, 2023

The reason is that we provide our own EditorTabTitleProvider which does not respect these settings. We should be able to solve this by sub classing UniqueNameEditorTabTitleProvider (the platform provider that respects the settings) and overriding it where needed for our use cases.

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Sep 4, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Sep 5, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Sep 5, 2023
@adietish adietish moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors Sep 5, 2023
adietish added a commit that referenced this issue Sep 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working severity/major
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants