Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated plugin, marking it compat <= 24.2 (#260) #261

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: deprecated plugin, marking it compat <= 24.2 (#260) #261

merged 2 commits into from
Oct 28, 2024

Conversation

adietish
Copy link
Contributor

fixes #260

@adietish adietish requested review from sbouchet and lgrossma October 28, 2024 12:57
@adietish
Copy link
Contributor Author

adietish commented Oct 28, 2024 •
edited
Loading

@lgrossma, @sbouchet: added a comment in README and set the upper bound of the compatibility range (until-build="242.*"). Missing something?

Please review.

ps. I also bumped all actions to v4 so that checks would pass.

@adietish adietish self-assigned this Oct 28, 2024
@adietish adietish changed the title fix: deprecated plugin, marking it compat >= 24.2 (#260) fix: deprecated plugin, marking it compat <= 24.2 (#260) Oct 28, 2024
sbouchet
sbouchet reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the missing IJ compatible version in workflow.

.github/workflows/IJ.yml Show resolved Hide resolved
@adietish
Copy link
Contributor Author

adietish commented Oct 28, 2024 •
edited
Loading

@sbouchet: my bad. It can of course not be built against 2024.2 (kotlin build script, 2.x gradle plugin etc.), but is compatible to it.
image
I thus kept the upper bound but removed 2024.2 from the build matrix

sbouchet
sbouchet approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adietish adietish merged commit bf524a8 into redhat-developer:main Oct 28, 2024
23 checks passed
@adietish adietish deleted the issue-260 branch October 28, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

@lgrossma lgrossma Awaiting requested review from lgrossma

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate intelllij-knative
2 participants
@adietish @sbouchet