fix: corrected deprecated API (#254) #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR red flags would be gone: |
adietish
commented
Apr 19, 2024
src/main/java/com/redhat/devtools/intellij/knative/tree/KnFunctionsTreeStructure.java
Outdated
Show resolved
Hide resolved
|
The plugin would be still compatible even without fixing the module API defect. I tend to leave it as is since we're slowly fading out this plugin. @sbouchet had an idea though how this defect can be fixed since he had done something similar in openshift. I wait for him to report back. |
sbouchet
approved these changes
Apr 22, 2024
Signed-off-by: Andre Dietisheim <[email protected]>
|
Submitted 1.3.8 for approval: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254