Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check checksums when downloading tools from json #230

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

sbouchet
Copy link
Contributor

fixes #214

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sbouchet sbouchet requested a review from adietish May 30, 2024 16:10
Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented on minor nitpicks. LGTM

Signed-off-by: Stephane Bouchet <[email protected]>
@sbouchet sbouchet requested a review from adietish June 20, 2024 14:08
@sbouchet
Copy link
Contributor Author

@adietish please re-view my small fixes

Copy link
Contributor

@adietish adietish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesomeness, looks better to my gusto. LGTM

@sbouchet sbouchet merged commit 43e00da into redhat-developer:main Jun 21, 2024
9 checks passed
@sbouchet sbouchet deleted the issue-214 branch June 21, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: check checksums when downloading tools from json
2 participants