SONAR ROUND 2

Signed-off-by: Zbynek Cervinka <[email protected]>

src/main/java/com/redhat/devtools/intellij/commonuitest/fixtures/dialogs/FlatWelcomeFrame.java

@@ -57,10 +57,10 @@
 public class FlatWelcomeFrame extends CommonContainerFixture {
     private static final Logger LOGGER = Logger.getLogger(FlatWelcomeFrame.class.getName());
     private static final String PROJECTS_BUTTON = "Projects";
+    private static final String TIP_OF_THE_DAY = "Tip of the Day";
     private final RemoteRobot remoteRobot;
     private final IntelliJVersion intelliJVersion;
     private final int ideaVersion;
-    private final String TIP_OF_THE_DAY = "Tip of the Day";
 
     public FlatWelcomeFrame(@NotNull RemoteRobot remoteRobot, @NotNull RemoteComponent remoteComponent) {
         super(remoteRobot, remoteComponent);

src/test-project/src/test/java/com/redhat/devtools/intellij/commonuitest/fixtures/test/dialogs/project_manipulation/NewProjectDialogTest.java

@@ -54,14 +54,13 @@ public class NewProjectDialogTest extends LibraryTestBase {
     private static final String PLAIN_JAVA_PROJECT_NAME = "plain_java_project_name_test";
     private static final String MORE_SETTINGS_SHOULD_BE_VISIBLE = "The 'More Settings' should be visible.";
     private static final String MORE_SETTINGS_SHOULD_BE_HIDDEN = "The 'More Settings' should be hidden.";
+    private static final String ADVANCED_SETTINGS_SHOULD_BE_OPENED_MSG = "The 'Advanced Settings' section should be opened but is not";
+    private static final String ADVANCED_SETTINGS_SHOULD_BE_CLOSED_MSG = "The 'Advanced Settings' section should be closed but is not";
     private static final String BUT_IS = "but is";
 
     private NewProjectDialogWizard newProjectDialogWizard;
     private NewProjectFirstPage newProjectFirstPage;
     private MainIdeWindow mainIdeWindow;
-    private final String ADVANCED_SETTINGS_SHOULD_BE_OPENED_MSG = "The 'Advanced Settings' section should be opened but is not";
-    private final String ADVANCED_SETTINGS_SHOULD_BE_CLOSED_MSG = "The 'Advanced Settings' section should be closed but is not";
-
 
     @BeforeEach
     public void openNewProjectDialog() {

src/test-project/src/test/java/com/redhat/devtools/intellij/commonuitest/fixtures/test/dialogs/settings/SettingsDialogTest.java

@@ -40,8 +40,8 @@
 class SettingsDialogTest extends LibraryTestBase {
     private static FlatWelcomeFrame flatWelcomeFrame;
     private SettingsDialog settingsDialog = null;
-    private final String APPEARANCE_AND_BEHAVIOR = "Appearance & Behavior";
-    private final String NOTIFICATIONS = "Notifications";
+    private static final String APPEARANCE_AND_BEHAVIOR = "Appearance & Behavior";
+    private static final String NOTIFICATIONS = "Notifications";
 
     @BeforeAll
     public static void openSettingsDialog() {