feat: add support for sidecar container in controller and server #758
Conversation
| .PHONY: operator-sdk | ||
| OPERATOR_SDK ?= $(LOCALBIN)/operator-sdk | ||
| operator-sdk: ## Download operator-sdk locally if necessary. | ||
| ifeq (,$(wildcard $(OPERATOR_SDK))) | ||
| @{ \ | ||
| set -e ;\ | ||
| mkdir -p $(dir $(OPERATOR_SDK)) ;\ | ||
| OS=$(shell go env GOOS) && ARCH=$(shell go env GOARCH) && \ | ||
| curl -sSLo $(OPERATOR_SDK) https://github.com/operator-framework/operator-sdk/releases/download/$(OPERATOR_SDK_VERSION)/operator-sdk_$${OS}_$${ARCH} ;\ | ||
| chmod +x $(OPERATOR_SDK) ;\ | ||
| } | ||
| endif |
There was a problem hiding this comment.
Yes @svghadi
|
/retest |
|
/lgtm |
| @@ -1,3 +1,7 @@ | |||
| apiVersion: kuttl.dev/v1beta1 | |||
There was a problem hiding this comment.
@iam-veeramalla usual timeout for parallel tests is 1200s. By adding a timeout in this file, it'll be overridden. Is this intentional?
There was a problem hiding this comment.
I think, this test is failing due to mismatch in the order of the volume mounts.
There was a problem hiding this comment.
Yeah, the test is passing now. We can probably get rid of the timeout
|
if the side car containers are dynamically injected by other operators (say istio), gitops-operator should ignore such updates right ? Are we handing that use case ? |
I don't think we have considered such use-cases where external apps will inject sidecar into operator. |
|
@iam-veeramalla could you please update the toolchain test |
That's a very good point @anandf , Thank you. However, that change is required in Argo CD Operator. This repository should not be impacted by the changes you suggested. This PR only contains the API changes, Tests and Manifests changes which can be merged. Once I get the suggested change in to the Argo CD Operator, we can just update the go.mod in this repository to pick the latest Argo CD Operator changes. |
Signed-off-by: iam-veeramalla <[email protected]>
Signed-off-by: iam-veeramalla <[email protected]>
Signed-off-by: iam-veeramalla <[email protected]>
Signed-off-by: iam-veeramalla <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 990a1f9
into
redhat-developer:master
…hat-developer#758) * feat: add support for sidecar container in controller and server Signed-off-by: iam-veeramalla <[email protected]> * fix: failing test due to timeout Signed-off-by: iam-veeramalla <[email protected]> * fix: failing tests Signed-off-by: iam-veeramalla <[email protected]> * fix: manifests updates Signed-off-by: iam-veeramalla <[email protected]> --------- Signed-off-by: iam-veeramalla <[email protected]>
What type of PR is this?
What does this PR do / why we need it:
Adds support for Sidecar container in Controller and Server
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Adds support for Sidecar container in Controller and Server
How to test changes / Special notes to the reviewer:
1-106_validate_appcontroller_initcontainers1-107_validate_server_initcontainers1-108_validate_appcontroller_sidecar1-109_validate_server_sidecar