Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PR #1401 from argocd-operator #728

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

chetan-rns
Copy link
Member

@chetan-rns chetan-rns commented Jun 6, 2024

What type of PR is this?

/kind bug

What does this PR do / why we need it:
Include argoproj-labs/argocd-operator#1401 from the argocd-operator

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-4778

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Chetan Banavikalmutt <[email protected]>
@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Jun 6, 2024
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chetan-rns. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chetan-rns
Copy link
Member Author

/retest

1 similar comment
@chetan-rns
Copy link
Member Author

/retest

Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwest jgwest merged commit 87f9693 into redhat-developer:master Jun 6, 2024
17 of 18 checks passed
anandf pushed a commit to anandf/gitops-operator that referenced this pull request Jun 10, 2024
Signed-off-by: Chetan Banavikalmutt <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants