Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: 1-035_validate_argocd_secret_repopulate #545

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

varshab1210
Copy link
Member

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

Re write timeout strategy for test 1-035_validate_argocd_secret_repopulate

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://issues.redhat.com/browse/GITOPS-2998

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Jun 26, 2023
@varshab1210
Copy link
Member Author

/test all

2 similar comments
@varshab1210
Copy link
Member Author

/test all

@varshab1210
Copy link
Member Author

/test all

@varshab1210
Copy link
Member Author

/test v4.10-e2e

@varshab1210 varshab1210 marked this pull request as ready for review July 11, 2023 10:00
@varshab1210
Copy link
Member Author

/test v4.10-e2e

@anandrkskd
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Jul 20, 2023
@anandrkskd
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 20, 2023
@openshift-ci openshift-ci bot removed the lgtm label Jul 25, 2023
@varshab1210
Copy link
Member Author

/test v4.10-e2e

@reginapizza
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Jul 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

New changes are detected. LGTM label has been removed.

@jaideepr97
Copy link
Collaborator

/lgtm
/approved

@jaideepr97
Copy link
Collaborator

/lgtm

@jaideepr97
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaideepr97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaideepr97 jaideepr97 added lgtm and removed kind/failing-test Categorizes issue or PR as related to a frequently failing test. labels Jul 27, 2023
@jaideepr97 jaideepr97 merged commit e3dbee6 into redhat-developer:master Jul 27, 2023
1 check passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Re-write timeout strategy for test 1-035_validate_argocd_secret_repopulate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants