Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kuttl tests #534

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Add Kuttl tests #534

merged 8 commits into from
Jul 13, 2023

Conversation

mehabhalodiya
Copy link
Contributor

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
Now that we have started storing tests in gitops-operator repository, we need to make sure it is up to date.

NOTE: I am still looking to add more as I am figuring out what's missing; so marking this Draft PR.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-2988

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

Hi @mehabhalodiya. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mehabhalodiya
Add test to validate the Dex Client Secret
9bbd225 
Signed-off-by: mehabhalodiya <[email protected]>
Signed-off-by: mbhalodi <[email protected]>
@mehabhalodiya mehabhalodiya force-pushed the kuttl-tests-modifications branch 2 times, most recently from 45b464d to 9bbd225 Compare June 14, 2023 05:51
@mehabhalodiya mehabhalodiya changed the title Add test to validate the Dex Client Secret Add test for validations Jun 14, 2023
@mehabhalodiya mehabhalodiya marked this pull request as ready for review June 14, 2023 10:11
@mehabhalodiya mehabhalodiya changed the title Add test for validations Add Kuttl tests Jun 14, 2023
@svghadi svghadi mentioned this pull request Jun 15, 2023
Closed
@varshab1210
Copy link
Member

/ok-to-test

@varshab1210 varshab1210 reopened this Jun 15, 2023
@varshab1210
Copy link
Member

/ok-to-test

@mehabhalodiya
Copy link
Contributor Author

/retest

@varshab1210
Copy link
Member

/test v4.12-kuttl-sequential

@mehabhalodiya
Add sequential tests
86de46c 
Signed-off-by: mehabhalodiya <[email protected]>
@varshab1210
Copy link
Member

/retest

@mehabhalodiya mehabhalodiya changed the title Add Kuttl tests Add Kuttl tests for v1.9 Jun 16, 2023
@mehabhalodiya mehabhalodiya changed the title Add Kuttl tests for v1.9 Add Kuttl tests Jun 27, 2023
@mehabhalodiya
Copy link
Contributor Author

/retest

@mehabhalodiya
rename the file
3e49651 
Signed-off-by: mehabhalodiya <[email protected]>
@varshab1210
Copy link
Member

/test v4.12-e2e

1 similar comment
@varshab1210
Copy link
Member

/test v4.12-e2e

@varshab1210
Copy link
Member

/lgtm
Thanks @mehabhalodiya !

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2023
@iam-veeramalla
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f4a3aa3 into redhat-developer:master Jul 13, 2023
1 check passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
@mehabhalodiya @varshab1210
Add Kuttl tests (redhat-developer#534)
9fd3158 
* Add test to validate the Dex Client Secret

Signed-off-by: mehabhalodiya <[email protected]>
Signed-off-by: mbhalodi <[email protected]>

* Add test to validate the server autoscale

Signed-off-by: mehabhalodiya <[email protected]>

* Add test to validate rollout resources creation and policyrules

Signed-off-by: mehabhalodiya <[email protected]>

* Add test to validate the terminating namespaces

Signed-off-by: mehabhalodiya <[email protected]>

* Add sequential tests

Signed-off-by: mehabhalodiya <[email protected]>

* rename the file

Signed-off-by: mehabhalodiya <[email protected]>

---------

Signed-off-by: mehabhalodiya <[email protected]>
Signed-off-by: mbhalodi <[email protected]>
Co-authored-by: Varsha B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshab1210 varshab1210 varshab1210 left review comments

@svghadi svghadi svghadi left review comments

@chetan-rns chetan-rns Awaiting requested review from chetan-rns

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@varshab1210 varshab1210

Labels
approved kind/enhancement New feature or request lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mehabhalodiya @varshab1210 @iam-veeramalla @svghadi @openshift-merge-robot