Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migration to non-OLM installation and using regctl for extracting CSV info from bundle image #531

Merged

Conversation

anandf
Copy link
Member

@anandf anandf commented Jun 9, 2023

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
Improve the manifest based installation script (non-OLM installation) by removing the dependency on either docker or podman and instead using a lightweight binary regctl to extract the ClusterServiceVersion from within the bundle image. Since this binary gets automatically installed and uninstalled if not present on the host system, its easy for users to run the installation script without going through the overheads of setting up docker or podman on their host systems.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jun 9, 2023
@openshift-ci openshift-ci bot requested review from chetan-rns and jgwest June 9, 2023 18:09
@varshab1210
Copy link
Member

/retest

@anandf anandf changed the title Using regctl instead of docker or podman to get CSV from bundle image Support migration to non-OLM installation and using regctl for extracting CSV info from bundle image Jul 4, 2023
Copy link
Member

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the script and migration was successful.

hack/non-olm-install/README.md Show resolved Hide resolved
@anandf
Copy link
Member Author

anandf commented Jul 11, 2023

/retest-required

@anandf
Copy link
Member Author

anandf commented Jul 11, 2023

/retest-required

ishitasequeira
ishitasequeira previously approved these changes Jul 11, 2023
Copy link
Collaborator

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Tested the Install, Migrate and Uninstall workflows successfully


```
OPERATOR_REGISTRY=brew.registry.redhat.io OPERATOR_REGISTRY_ORG=rh-osbs IMAGE_PREFIX=openshift-gitops-1- GITOPS_OPERATOR_VER=v99.9.0-<build_number> ./install-gitops-operator.sh -m
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an example of Migrate with basic default params as well?

@anandf
Copy link
Member Author

anandf commented Jul 11, 2023

/retest-required

@anandf
Copy link
Member Author

anandf commented Jul 11, 2023

/retest-required

@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/retest

1 similar comment
@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/retest

@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2023

@anandf: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/retest

@saumeya
Copy link
Member

saumeya commented Jul 12, 2023

/lgtm

@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/test v4.10-kuttl-sequential

@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/retest

@ishitasequeira
Copy link
Collaborator

/lgtm
/approve

@anandf
Copy link
Member Author

anandf commented Jul 12, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf, ishitasequeira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saumeya
Copy link
Member

saumeya commented Jul 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5e51eed into redhat-developer:master Jul 13, 2023
1 check passed
@anandf anandf deleted the non_olm_regctl_use branch August 31, 2023 05:42
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants