-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support migration to non-OLM installation and using regctl for extracting CSV info from bundle image #531
Support migration to non-OLM installation and using regctl for extracting CSV info from bundle image #531
Conversation
52b76e1
to
a3ee0f4
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the script and migration was successful.
/retest-required |
33bf8bd
to
a134c3b
Compare
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Tested the Install, Migrate and Uninstall workflows successfully
|
||
``` | ||
OPERATOR_REGISTRY=brew.registry.redhat.io OPERATOR_REGISTRY_ORG=rh-osbs IMAGE_PREFIX=openshift-gitops-1- GITOPS_OPERATOR_VER=v99.9.0-<build_number> ./install-gitops-operator.sh -m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add an example of Migrate with basic default params as well?
/retest-required |
a134c3b
to
a3dde8a
Compare
/retest-required |
/retest |
1 similar comment
/retest |
/lgtm |
@anandf: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
/test v4.10-kuttl-sequential |
8beacc5
to
14a63c7
Compare
/retest |
/lgtm |
…gctl Signed-off-by: Anand Francis Joseph <[email protected]>
14a63c7
to
a2c435c
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf, ishitasequeira The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
5e51eed
into
redhat-developer:master
…gctl (redhat-developer#531) Signed-off-by: Anand Francis Joseph <[email protected]>
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Improve the manifest based installation script (non-OLM installation) by removing the dependency on either
docker
orpodman
and instead using a lightweight binaryregctl
to extract theClusterServiceVersion
from within the bundle image. Since this binary gets automatically installed and uninstalled if not present on the host system, its easy for users to run the installation script without going through the overheads of setting updocker
orpodman
on their host systems.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: