Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use post-start event to start VS Code #921

Merged
merged 1 commit into from
Mar 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions dependencies/che-plugin-registry/che-editors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,15 @@ editors:
- id: init-container-command
apply:
component: che-code-injector
- id: init-che-code-command
exec:
component: che-code-runtime-description
commandLine: 'nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt 2>&1 &'
events:
preStart:
- init-container-command
postStart:
- init-che-code-command
components:
- name: che-code-injector
container:
Expand All @@ -319,8 +325,6 @@ editors:
memoryRequest: 256Mi
cpuLimit: 500m
cpuRequest: 30m
command:
- /checode/entrypoint-volume.sh
volumeMounts:
- name: checode
path: /checode
Expand Down Expand Up @@ -379,9 +383,15 @@ editors:
- id: init-container-command
apply:
component: che-code-injector
- id: init-che-code-command
exec:
component: che-code-runtime-description
commandLine: 'nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt 2>&1 &'
events:
preStart:
- init-container-command
postStart:
- init-che-code-command
components:
- name: che-code-injector
container:
Expand All @@ -401,8 +411,6 @@ editors:
memoryRequest: 256Mi
cpuLimit: 500m
cpuRequest: 30m
command:
- /checode/entrypoint-volume.sh
volumeMounts:
- name: checode
path: /checode
Expand Down