Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate devworkspaces by devworkspace-generator tool #870

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Dec 30, 2022

Signed-off-by: Valerii Svydenko [email protected]

What does this PR do?

Uses che-devworkspace-generator tool to generate DevWorkspaces with container contribution attributes.

For more details see the upstream PR:
eclipse-che/che-devfile-registry#690

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3613

Release Notes

Docs PR (if applicable)

@nickboldt
Copy link
Member

does this change any of the GHA / jenkins / webhook triggering we have in place for rebuilding devfile or plugin registry when upstream changes happen? does devfile reg still need to be rebuilt when plugin reg is rebuilt?

https://github.com/redhat-developer/devspaces/commits/devspaces-3.3-rhel-8/dependencies/che-devfile-registry/webhook_trigger.txt

@svor
Copy link
Contributor Author

svor commented Jan 9, 2023

As far as I know it doesn't change any GHA / jenkins / webhook.

does devfile reg still need to be rebuilt when plugin reg is rebuilt

Yes, it does. Devfile reg depends on the editors provided by plugin reg

@svor svor merged commit dc9c576 into devspaces-3-rhel-8 Jan 9, 2023
@svor svor deleted the sv-devworkspace-contribution branch January 9, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants