Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Openshift connector plugin to latest version #530

Closed
wants to merge 2 commits into from
Closed

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jun 22, 2021

Signed-off-by: Igor Vinokur [email protected]

What does this PR do?

Update the Openshift connector plugin to latest version

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1733

Release Notes

Docs PR (if applicable)

@vitaliy-guliy
Copy link
Contributor

I suppose Signed-off-by should contain Red Hat email

Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the dependencies in the sidecar need to be updated. Please also make this change upstream.

sidecar:
image: "registry.redhat.io/codeready-workspaces/plugin-openshift-rhel8:2.10"
name: vscode-openshift-connector
memoryLimit: 1500Mi
cpuLimit: 500m
cpuRequest: 30m
extension: https://download.jboss.org/jbosstools/vscode/3rdparty/vscode-openshift-tools/vscode-openshift-connector-0.1.5.vsix
extension: https://github.com/redhat-developer/codeready-workspaces-vscode-extensions/releases/download/v31f30bd/vscode-openshift-connector-v0.2.7.vsix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the link is correct. The extension was built from source and published as a GitHub release asset: https://github.com/redhat-developer/codeready-workspaces-vscode-extensions

@vinokurig
Copy link
Contributor Author

@ericwill

I believe the dependencies in the sidecar need to be updated.

Could you please clarify what dependency is needed to be updated?

Please also make this change upstream.

I think it depends on eclipse-che/che#19361

…ide to avoid running on files that should not be linted

Change-Id: I46d9016249993dc1ab0d743f976bcfa49b9dae8a
Signed-off-by: nickboldt <[email protected]>
@nickboldt
Copy link
Member

Note that the Build PR check is failing because your fork cannot get access to secrets.

So here's a replacement PR #542

@nickboldt nickboldt closed this Jul 5, 2021
@ericwill
Copy link
Contributor

ericwill commented Jul 5, 2021

@ericwill

I believe the dependencies in the sidecar need to be updated.

Could you please clarify what dependency is needed to be updated?

In the upstream plugin repository, there is a list: https://github.com/redhat-developer/vscode-openshift-tools/blob/master/src/tools.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants