feat: Support ubi9-based containers for running VS Code editor #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
working on adaptation of |
RomanNikitenko
force-pushed
the
support-ubi9-based-containers
branch
2 times, most recently
from
3190406 to
ff29a83
Compare
RomanNikitenko
force-pushed
the
support-ubi9-based-containers
branch
2 times, most recently
from
f1849a8 to
1f88c3a
Compare
Signed-off-by: Roman Nikitenko <[email protected]>
Signed-off-by: Roman Nikitenko <[email protected]>
RomanNikitenko
force-pushed
the
support-ubi9-based-containers
branch
from
1f88c3a to
b59d3c7
Compare
|
WildFly Bootable Jar sample has musl/alpine-based container, it's not supported by devspaces-code. |
RomanNikitenko
requested review from
svor,
ibuziuk and
SDawley
as code owners
ibuziuk
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dockerfilefor the local build of thedevspaces-codedoesn't work, so it's not possible to builddevspaces-codeassembly. The current PR fixes thatDockerfile.ubi9-based assembly for both: local build and build on Brew.musl/alpine-basedcontainers support for runningdevspaces-codeSupport ubi9-based containers for running VS Code editor:
registry.access.redhat.com/ubi9/nodejs-18is used for running VS Code in aubi9-basedcontainerlibbrotlilibrary from the same image is copied to a user's container as a dependency for Node.jsLD_LIBRARY_PATHenv variable to define additional shared libs place (libbrotli)What issues does this PR fix?
https://issues.redhat.com/browse/CRW-5629
How to test this PR?
Image for testing: quay.io/rnikitenko/devspaces-code:ubi8-ubi9-jenkins
Successful build on jenkins: DS_CI/job/get-sources-rhpkg-container-build_3.x/6138
I tested the following images as a container for running Devspaces Code:
registry.access.redhat.com/ubi8Git not found
registry.access.redhat.com/ubi9Git not found
registry.access.redhat.com/ubi9/ubi:9.3-1476Git not found
registry.access.redhat.com/ubi9/ubi-minimal:9.3-1475Git not found
registry.access.redhat.com/ubi9/podman:9.3-8Git not found
registry.access.redhat.com/ubi9/perl-532:1-121registry.access.redhat.com/ubi9/php-81:1-43registry.access.redhat.com/ubi9/ruby-30:1-138registry.access.redhat.com/ubi9/openjdk-21-runtimeGit not found
registry.access.redhat.com/ubi9/nodejs-16:1-143registry.access.redhat.com/ubi9/nodejs-18:1-84registry.access.redhat.com/ubi9/nodejs-20:1-20registry.access.redhat.com/ubi9/openjdk-11:1.17-1.1705602311Git not found
registry.access.redhat.com/ubi9/openjdk-17:1.17-1Git not found
registry.access.redhat.com/ubi9/go-toolset:1.19.13-4.1697647145registry.access.redhat.com/ubi8/nodejs-16:latestregistry.access.redhat.com/ubi9/python-39:1-161registry.access.redhat.com/ubi9/python-39:1-161registry.access.redhat.com/ubi8/openjdk-17:1.18-2Git not found
quay.io/eclipse/che-java11-maven:7.37.2the cause of the problem
quay.io/jaegertracing/all-in-one:1.50the cause of the problem