Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async support #206

Open
r00ta opened this issue Feb 17, 2022 · 7 comments
Open

Add async support #206

r00ta opened this issue Feb 17, 2022 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@r00ta
Copy link

r00ta commented Feb 17, 2022

Hi,

The api exposed by the sdk are not async.
We had to implement an abstraction over the sdk so to introduce such async api calls to be used in our services. This is not an ideal solution since I think the sdk should provide such functionality out of the box. Wdyt?

Thank you very much

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 17, 2022

This is very valid request - I believe that we were getting a lots of requests for asnyc api before.
Can you contribute your wrapper to the repository?

The problem with async is that we would have issue with being opinionated and so far every proposition we given to the team ended with response: Ok That will not work for us we use X - where X is some nishe lib used only in redhat.

OpenAPI generator offers rxjava flavour that we can generate out of the box and publish as -async versions of the SDK

@wtrocki wtrocki added the help wanted Extra attention is needed label Feb 17, 2022
@r00ta
Copy link
Author

r00ta commented Feb 21, 2022

Hi @wtrocki , I don't think our async wrapper is the right way to solve the problem and make it available to the public. If we have to keep the sync implementation, would it be possible to have another async sdk generated with the openapi generator?

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 21, 2022

We do not write any code in the repo all sdks are generated.

Can you tell me what generators client you would require to use? See OpenApiGenerator availabe generators for reference.

@r00ta
Copy link
Author

r00ta commented Feb 23, 2022

We do not write any code in the repo all sdks are generated.

Can you tell me what generators client you would require to use? See OpenApiGenerator availabe generators for reference.

I need some time to get though that tool. I'll get back to you in the next days

@wtrocki
Copy link
Collaborator

wtrocki commented Mar 3, 2022

@r00ta There is only one async generator for the Java (rxjava) is that something your team would like to have?

@wtrocki
Copy link
Collaborator

wtrocki commented Mar 3, 2022

Actually I see that there is Async Support in the Generator itself:
OpenAPITools/openapi-generator#4721

That will require us moving from quarkus supported client resteasy to native clients.
I have tested it and it seems to be failing on some specifics of that OpenAPI file but technically that would be possible.

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 6, 2022

andreaTP pushed a commit to andreaTP/app-services-sdk-java that referenced this issue Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants