Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-selection): add ability to auto select the tab based on available data #19

Merged

Conversation

karthikjeeyar
Copy link
Collaborator

@karthikjeeyar karthikjeeyar commented Feb 12, 2024

Fixes:

#18
https://issues.redhat.com/browse/DEVUI-16

How to test:

Do not pass the acsImageScan data to the output component.

<Output
      enterpriseContractPolicies={mockEnterpriseContractUIData ?? []}
      acsImageCheckResults={acsImageCheckResults}
      acsDeploymentCheckResults={acsDeploymentCheckResults}
      results={pipelineRun?.status?.results
      pipelineRunName={pipelineRun?.metadata?.name}
      pipelineRunStatus={'Succeeded'}
    />

Screenshot:

image

Unit test:

  useFirstLoadedInput
    ✓ should handle the invalid value (14 ms)
    ✓ should return the default value if the input value is empty (2 ms)
    ✓ should return the default value if the input value is undefined (2 ms)
    ✓ should identify the first input with some data in it (4 ms)
    ✓ should work with object values (3 ms)
    ✓ should work with string values (2 ms)

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: c9afa59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aonic-ui/pipelines Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a patch changeset for this as well.

Copy link
Collaborator

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates a PR is ready to be merged. label Feb 13, 2024
@rohitkrai03 rohitkrai03 merged commit f18f066 into redhat-developer:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants