Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): add tekton core type and Output component integration utils #16

Merged

Conversation

karthikjeeyar
Copy link
Collaborator

This PR contains the following changes

  1. Add Tekton core types.
  2. Add output integration utils, hooks and unit tests.
  3. Add sample data helper utility to compose pipelinerun, taskruns and pods.
  4. Add tech documentation and update readme.

Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: 50afe89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aonic-ui/pipelines Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karthikjeeyar karthikjeeyar changed the title Add tekton core type and Output component integration utils feat(pipelines): add tekton core type and Output component integration utils Feb 8, 2024
formatData(ecTaskFormat, ecValue ?? ([] as any)) as EnterpriseContractResult,
);

return {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use React.useMemo here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Collaborator

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates a PR is ready to be merged. label Feb 13, 2024
@rohitkrai03 rohitkrai03 merged commit e44299e into redhat-developer:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants