-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I think we have also to update the .github/workflows/release.yaml as it builds the java implementation.
-
On the testing side (maybe you have already checked that) but IDK if there are any test resources used only from JS and Java.
Signed-off-by: Michael Hoang <[email protected]>
I removed the release workflow as it doesn't seem to be in use at all
There's two projects that don't seem to be used in the tests, but I'll remove them with #177 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'd say before merging we should let everyone know that we are going to remove them permanetly
Check with the collaborators before removing these implementations |
Closing for now; will need to find a place to archive before removing these implementations |
Maybe we can put a label (e.g on hold) and keep it open. We could also update the issue with the required steps we have discussed? WDYT? |
Hi @mohitsuman, it looks like the vscode-tekton and intellij-tekton projects are using the deprecated java and js alizer implementations. Are there any concerns with removing these implementations? |
@mike-hoang Yes the tekton extensions use alizer to list down the Tekton Hub list. And the logic used there is based on JS implementation. Can you let me know why are we deprecating the JS and Java based implementation. I understand it will be outdated with Go version and it makes sense to update one language, but given the implementations we already have it the past, it should be kept in the project. |
@mohitsuman thanks for the update! cc @elsony |
@mohitsuman To clarify: This repo will be used for the go implementation only which we intended to move under the CNCF devfile project. Since the js and Java implementations are no longer under active development, we don't want them to be included as part of the CNCF project. We have moved the js and Java implementation code from the current repo to a separate repo (https://github.com/devfile-resources/alizer) for archiving purposes. |
@elsony Thanks for the update. I am fine having alizer to have only go implementation and help in solving the devfile use cases. And as we have a separate repo for JS and Java, we can sync how the current go lang version can be used to replace that login in IDE extension (if needed). So 👍🏼 for having this repo without the non-active implementations. |
New changes are detected. LGTM label has been removed. |
What does this PR do?
Removes the deprecated javascript and java implementations. An archived version of alizer with the removed implementations are stored here: https://github.com/devfile-resources/alizer
Which issue(s) this PR fixes:
fixes #172 and fixes #173