Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

removing js and java implementations #192

Merged
merged 2 commits into from
May 10, 2023

Conversation

mike-hoang
Copy link
Contributor

@mike-hoang mike-hoang commented Apr 19, 2023

What does this PR do?

Removes the deprecated javascript and java implementations. An archived version of alizer with the removed implementations are stored here: https://github.com/devfile-resources/alizer

Which issue(s) this PR fixes:

fixes #172 and fixes #173

@mike-hoang mike-hoang requested a review from thepetk April 19, 2023 21:53
@mike-hoang mike-hoang self-assigned this Apr 19, 2023
Copy link
Collaborator

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think we have also to update the .github/workflows/release.yaml as it builds the java implementation.

  • On the testing side (maybe you have already checked that) but IDK if there are any test resources used only from JS and Java.

@mike-hoang
Copy link
Contributor Author

I removed the release workflow as it doesn't seem to be in use at all

  • On the testing side (maybe you have already checked that) but IDK if there are any test resources used only from JS and Java.

There's two projects that don't seem to be used in the tests, but I'll remove them with #177

Copy link
Collaborator

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'd say before merging we should let everyone know that we are going to remove them permanetly

@maysunfaisal
Copy link
Collaborator

Check with the collaborators before removing these implementations

@mike-hoang
Copy link
Contributor Author

Closing for now; will need to find a place to archive before removing these implementations

@mike-hoang mike-hoang closed this Apr 20, 2023
@thepetk
Copy link
Collaborator

thepetk commented Apr 21, 2023

Maybe we can put a label (e.g on hold) and keep it open. We could also update the issue with the required steps we have discussed? WDYT?

@mike-hoang mike-hoang reopened this Apr 26, 2023
@mike-hoang
Copy link
Contributor Author

Hi @mohitsuman, it looks like the vscode-tekton and intellij-tekton projects are using the deprecated java and js alizer implementations. Are there any concerns with removing these implementations?

@mohitsuman
Copy link
Collaborator

@mike-hoang Yes the tekton extensions use alizer to list down the Tekton Hub list. And the logic used there is based on JS implementation. Can you let me know why are we deprecating the JS and Java based implementation. I understand it will be outdated with Go version and it makes sense to update one language, but given the implementations we already have it the past, it should be kept in the project.

@mike-hoang
Copy link
Contributor Author

Can you let me know why are we deprecating the JS and Java based implementation.

@mohitsuman thanks for the update!
The reason for deprecating is because the alizer project will be onboarded to devfile. Before we move the project, we want the state to be the same which means removing the JS and Java implementations since we will no longer support them

cc @elsony

@elsony
Copy link
Collaborator

elsony commented May 10, 2023

@mohitsuman To clarify: This repo will be used for the go implementation only which we intended to move under the CNCF devfile project. Since the js and Java implementations are no longer under active development, we don't want them to be included as part of the CNCF project. We have moved the js and Java implementation code from the current repo to a separate repo (https://github.com/devfile-resources/alizer) for archiving purposes.

@mohitsuman
Copy link
Collaborator

@elsony Thanks for the update. I am fine having alizer to have only go implementation and help in solving the devfile use cases. And as we have a separate repo for JS and Java, we can sync how the current go lang version can be used to replace that login in IDE extension (if needed).

So 👍🏼 for having this repo without the non-active implementations.

@openshift-ci openshift-ci bot removed the lgtm label May 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

New changes are detected. LGTM label has been removed.

@mike-hoang mike-hoang merged commit c917df6 into redhat-developer:main May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Java and JS builds and intergration tests from workflow Remove JS and Java implementation
5 participants