add(): add CRD for GCPAuthEngineConfig #242
Conversation
|
@erlisb could you resolve the conflicts? |
|
Done |
|
there is something wrong here, the |
config/webhook/manifests.yaml
Outdated
| @@ -89,9 +89,9 @@ webhooks: | |||
| service: | |||
| name: webhook-service | |||
| namespace: system | |||
| path: /mutate-redhatcop-redhat-io-v1alpha1-databasesecretengineconfig | |||
| path: /mutate-redhatcop-redhat-io-v1alpha1-gcpauthengineconfig | |||
There was a problem hiding this comment.
is this correct, it seems you are replacing the databasesecretengineconfig, this file is automatically generated, just run make manifests
config/rbac/role.yaml
Outdated
| @@ -287,9 +287,6 @@ rules: | |||
| - get | |||
| - patch | |||
| - update | |||
| - apiGroups: | |||
There was a problem hiding this comment.
there is a problem here, again please generate this file with make config.
config/webhook/manifests.yaml
Outdated
| failurePolicy: Fail | ||
| name: mdatabasesecretengineconfig.kb.io |
There was a problem hiding this comment.
also these substitutions look suspicious, please regenerate this file with make manifests
|
@raffaelespazzoli I regenerated the affected manifests. Please, check again. Thanks. |
|
Hi @raffaelespazzoli kind reminder! |
|
@erlisb can you re-base and fix the conflicts |
This PR consists in :
API Resource / CRD for GCPAuthEngineConfig
Defaulter / Validator Webhook for GCPAuthEngineConfig CRD
Controller Reconciliator for for GCPAuthEngineConfig CRD
Documentation for GCPAuthEngineConfig CRD
@raffaelespazzoli , please review it.
Thnx