Cleanup task name #718
Closed
Cleanup task name #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This jinja2 template is never evaluated. The loop is inside the task. There is only one task and it was called literally:
"Run infra.controller_configuration.{{ __role.role }}"
|
I removed my linter cleanup commit. I think there is very many linter warnings right now. Might be possible to fix a lot of them with ansible-lint --write, but I think this is too much for this specific pull request. |
ivarmu
added
wontfix
|
Hi @dbk-rabel, I prefer to let the current names to work properly, as proposed in the PR #716 for giving a solution to the issue #707. So, if you feel confortable with this, we can close this issue as duplicated. |
Yes, that's sounds good. Thanks for putting in the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This jinja2 template is never evaluated. The loop is inside the task. There is only one task and it was called literally: "Run infra.controller_configuration.{{ __role.role }}"
Very similar to #708
Although in this case I'm not sure if my proposed task name is the best.
Yours
David