enable argo sync concurrent to CRD creation #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlbewley
requested review from
strangiato,
gnunn1,
pittar and
adetalhouet
as code owners
|
Thank you for the commit! I noticed that the nmstate operator wasn't following some of the newer standards we have been trying to follow, including an aggregate folder where we would normally set this annotation so I went ahead and did a quick refactor of the folder in another PR: Take a look over there and let me know what you think and if we can get that PR merged we can close this one without merging. |
|
Ah, I just noticed there is now a conflict after @strangiato refactored the nmstate dir structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip dry run validation on creation of nmstate resource.
This enables simultaneous sync of nmstate/operator and nmstate/instance kustomizations in a single Argo CD sync.