Upgraded all actions to latest versions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested via: redhat-cop/patch-operator#61 |
garethahealy
commented
Nov 16, 2023
| @@ -145,11 +145,8 @@ jobs: | |||
| # Controller-gen | |||
| make controller-gen | |||
|
|
|||
| # Kustomize | |||
| make kustomize | |||
|
|
|||
There was a problem hiding this comment.
I removed this because CI was failing. make bundle also runs kustomize so was getting "file exists" error. felt like the best place to fix this issue but happy to revert/change
raffaelespazzoli
approved these changes
Nov 16, 2023
|
LGTM, but I'd like more eyes on it. @sabre1041 @trevorbox can you also take a look? |
sabre1041
approved these changes
Nov 20, 2023
|
@trevorbox ; last one to review. it okay with you? |
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of the actions are out of date. Upgraded all (i think)