Fixed an issue where a tempfile was not created locally #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the remote machine
djdanielsson
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
I am interested to see if this will fix #148 or not, I think it is worth a try, worst case we make it a var and default localhost to allow people to override where delegation goes
|
I have tested with the HEAD of this git repo, and it is indeed working as expected. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where the ee_builder role running on a remote machine will fail because certain sections were delegated to localhost but others were not. This unifies the section to run only on localhost
How should this be tested?
See issue
Is there a relevant Issue open for this?
resolves #148
Other Relevant info, PRs, etc
N/A