Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating blue green pipeline with applier v2.0.3 #42

Merged
merged 8 commits into from
Oct 16, 2018

Conversation

etsauer
Copy link
Contributor

@etsauer etsauer commented Oct 4, 2018

What does this PR do?

see title

How should this be tested?

Run the following command:

echo "SOURCE_REPOSITORY_URL=https://github.com/etsauer/container-pipelines.git
SOURCE_REPOSITORY_REF=blue-green-applier-update" >> blue-green-spring/.openshift/builds/params

Then follow the Automated Deployment steps in blue-green-spring/README.md

Is there a relevant Issue open for this?

#39

Who would you like to review this?

cc: @redhat-cop/containers-approvers

@@ -1,5 +1,5 @@
APPLICATION_NAME=spring-boot-web
NAMESPACE=spring-boot-web-build
IMAGE_STREAM_TAG_NAME=redhat-openjdk18-openshift:1.1
SOURCE_REPOSITORY_URL=https://github.com/pabrahamsson/simple-spring-boot-web.git
SOURCE_REPOSITORY_REF=build
SOURCE_REPOSITORY_URL=https://github.com/etsauer/container-pipelines.git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it intentional to point to a person's repo here, rather than the redhat-cop repo?

@oybed
Copy link

oybed commented Oct 4, 2018

Would be nice to see an updated "Display Name" for these projects to allow for a "natural grouping" in the OpenShift web console. (like the "basic spring" deployment) - especially the "non-descriptive" name Build - Jenkins is here

@oybed
Copy link

oybed commented Oct 4, 2018

The build failed with the following error message in Jenkins:

 :
[spring-boot-web-build-spring-boot-web-pipeline] Running shell script
+ rm -rf oc-build
+ mkdir -p oc-build/deployments
++ echo 'jar;war;ear'
++ tr ';' '\n'
+ for t in '$(echo "jar;war;ear" | tr ";" "\n")'
+ cp -rfv ./target/shift-rest-0.1.0.jar oc-build/deployments/
'./target/shift-rest-0.1.0.jar' -> 'oc-build/deployments/shift-rest-0.1.0.jar'
+ for t in '$(echo "jar;war;ear" | tr ";" "\n")'
+ cp -rfv './target/*.war' oc-build/deployments/
+ echo 'No war files'
No war files
+ for t in '$(echo "jar;war;ear" | tr ";" "\n")'
+ cp -rfv './target/*.ear' oc-build/deployments/
+ echo 'No ear files'
No ear files
+ oc --request-timeout=0 --token=[hidden] --server=https://openshift.default.svc.cluster.local --certificate-authority=/run/secrets/kubernetes.io/serviceaccount/ca.crt --namespace=spring-boot-web-build start-build /spring-boot-web --from-dir=oc-build --wait=true --follow=true
error: a resource must be present, got: {  }
+ exit 1
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: script returned exit code 1
Finished: FAILURE

@etsauer
Copy link
Contributor Author

etsauer commented Oct 5, 2018

@oybed addressed your comments, and updated the testing instructions. hopefully that works for you now.

Copy link

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and found to be fully working now. Merging.

@oybed oybed merged commit bdea401 into redhat-cop:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants