-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating blue green pipeline with applier v2.0.3 #42
Conversation
@@ -1,5 +1,5 @@ | |||
APPLICATION_NAME=spring-boot-web | |||
NAMESPACE=spring-boot-web-build | |||
IMAGE_STREAM_TAG_NAME=redhat-openjdk18-openshift:1.1 | |||
SOURCE_REPOSITORY_URL=https://github.com/pabrahamsson/simple-spring-boot-web.git | |||
SOURCE_REPOSITORY_REF=build | |||
SOURCE_REPOSITORY_URL=https://github.com/etsauer/container-pipelines.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it intentional to point to a person's repo here, rather than the redhat-cop
repo?
Would be nice to see an updated "Display Name" for these projects to allow for a "natural grouping" in the OpenShift web console. (like the "basic spring" deployment) - especially the "non-descriptive" name |
The build failed with the following error message in Jenkins:
|
@oybed addressed your comments, and updated the testing instructions. hopefully that works for you now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and found to be fully working now. Merging.
What does this PR do?
see title
How should this be tested?
Run the following command:
Then follow the Automated Deployment steps in
blue-green-spring/README.md
Is there a relevant Issue open for this?
#39
Who would you like to review this?
cc: @redhat-cop/containers-approvers