Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Tomcat pipeline to v2.0.3 applier conventions #41

Merged
merged 16 commits into from
Oct 16, 2018

Conversation

etsauer
Copy link
Contributor

@etsauer etsauer commented Oct 4, 2018

What does this PR do?

See title.

How should this be tested?

Run the following command:

echo "SOURCE_REPOSITORY_URL=https://github.com/etsauer/container-pipelines.git
SOURCE_REPOSITORY_REF=basic-tomcat-applier-update" >> basic-tomcat/.openshift/builds/params

Then follow steps in basic-tomcat/README.md

Is there a relevant Issue open for this?

resolves #39

Who would you like to review this?

cc: @redhat-cop/containers-approvers @redhat-cop/developer-workflow-mergers

@oybed
Copy link

oybed commented Oct 4, 2018

Test failed with missing Jenkinsfile:

OpenShift Build basic-tomcat-build/basic-tomcat-pipeline-1 from https://github.com/pabrahamsson/ticket-monster.git
Checking out git https://github.com/pabrahamsson/ticket-monster.git into /var/lib/jenkins/jobs/basic-tomcat-build/jobs/basic-tomcat-build-basic-tomcat-pipeline/workspace@script to read Jenkinsfile
Cloning the remote Git repository
Cloning repository https://github.com/pabrahamsson/ticket-monster.git
 > git init /var/lib/jenkins/jobs/basic-tomcat-build/jobs/basic-tomcat-build-basic-tomcat-pipeline/workspace@script # timeout=10
Fetching upstream changes from https://github.com/pabrahamsson/ticket-monster.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/pabrahamsson/ticket-monster.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/pabrahamsson/ticket-monster.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/pabrahamsson/ticket-monster.git # timeout=10
Fetching upstream changes from https://github.com/pabrahamsson/ticket-monster.git
 > git fetch --tags --progress https://github.com/pabrahamsson/ticket-monster.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/build^{commit} # timeout=10
Checking out Revision aa5ede1c06d913afca54a864830024e37a17933f (origin/build)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f aa5ede1c06d913afca54a864830024e37a17933f
Commit message: "Support build namespace"
First time build. Skipping changelog.
ERROR: /var/lib/jenkins/jobs/basic-tomcat-build/jobs/basic-tomcat-build-basic-tomcat-pipeline/workspace@script/Jenkinsfile not found
Finished: FAILURE

@etsauer
Copy link
Contributor Author

etsauer commented Oct 5, 2018

@oybed addressed your comments. Note the added step in the PR comment above when testing.

@oybed oybed self-requested a review October 16, 2018 17:18
Copy link

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will write an issue to support

labels:
  app: ...

@oybed oybed merged commit 44691f9 into redhat-cop:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple spring boot doesn't work with the latest version of the applier.
2 participants