Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌲 FIX - broken selector on service and updated nginx image 🌳 #148

Merged
merged 1 commit into from
Oct 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion basic-nginx/.openshift/builds/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,4 @@ parameters:
- description: Image stream tag for the image you'd like to use to build the application
name: IMAGE_STREAM_TAG_NAME
required: true
value: nginx:1.12
value: nginx:1.14
1 change: 0 additions & 1 deletion basic-nginx/.openshift/deployment/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ objects:
protocol: TCP
targetPort: 8080
selector:
app: ${APPLICATION_NAME}
deploymentConfig: ${APPLICATION_NAME}
- apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
Expand Down
8 changes: 4 additions & 4 deletions basic-nginx/nginx.conf
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

worker_processes auto;
error_log stderr;
pid /var/opt/rh/rh-nginx112/run/nginx/nginx.pid;
pid /var/opt/rh/rh-nginx114/run/nginx/nginx.pid;

# Load dynamic modules. See /opt/rh/rh-nginx112/root/usr/share/doc/README.dynamic.
include /opt/rh/rh-nginx112/root/usr/share/nginx/modules/*.conf;
# Load dynamic modules. See /opt/rh/rh-nginx114/root/usr/share/doc/README.dynamic.
include /opt/rh/rh-nginx114/root/usr/share/nginx/modules/*.conf;

events {
worker_connections 1024;
Expand All @@ -25,7 +25,7 @@ http {
keepalive_timeout 65;
types_hash_max_size 2048;

include /etc/opt/rh/rh-nginx112/nginx/mime.types;
include /etc/opt/rh/rh-nginx114/nginx/mime.types;
default_type application/octet-stream;

# Load modular configuration files from the /etc/nginx/conf.d directory.
Expand Down