Add changes for Task and Pipeline using v1beta1 version instead of v1alpha1 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethahealy
reviewed
Jun 3, 2020
There was a problem hiding this comment.
@schen1 ; can you add a comment to the pre-reqs as to what the minimum version of tekton is needed:
Sure, it's now added. |
garethahealy
approved these changes
Jun 3, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethahealy, schen1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for v1beta1 API Version.
Task and Pipeline are impacted, the rest (such as PipelineResource) has not yet been promoted to v1beta1 version.
Release notes
How should this be tested?
Manual instruction guide has been used to test this.
Is there a relevant Issue open for this?
No issue opened for this.
Who would you like to review this?
cc: @redhat-cop/containers-approvers