-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A role to create S3 bucket with Dynamodb table for Terraform Backend #1
Conversation
abikouo
commented
Dec 13, 2023
•
edited
Loading
edited
- A new role to create S3 bucket with versioning enabled and optionally and create a Dynamodb table with a partition key named 'LockID' with type of String
- Add integration tests for the new role
fd7ea3e
to
8b35059
Compare
8b35059
to
82a6adc
Compare
e4ef8b0
to
075ca8e
Compare
@abikouo I also noticed that the Jira ticket specified "The role should be able to either accept an existing IAM role to be granted the above permissions or create a new one", which this doesn't currently do. But I'm not sure if that's actually necessary. @gravesm do we think optionally creating a new IAM role for managing terraform state should be part of this role? |
Are there reasons we wouldn't want to? IMO an IAM role is going to be the most common way that people will use to handle access to the backend. There's a whole config section in the s3 backend dedicated to assume role functionality. It seems like it should be easy enough for us to create the role, and would make this much more useful. |
Co-authored-by: Helen Bailey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, otherwise LGTM.