Add move_vm_from_on_prem_to_aws playbook and corresponding roles #95

alinabuzachis · 2023-09-12T15:22:56Z

Add move_vm_from_on_prem_to_aws playbook and corresponding roles

Requires ansible-collections/amazon.aws#1723

playbooks/move_vm_from_on_prem_to_aws/README.md

roles/clone_on_prem_vm/README.md

roles/clone_on_prem_vm/tasks/main.yml

roles/import_image_and_run_aws_instance/README.md

gravesm · 2023-09-20T17:50:49Z

playbooks/move_vm_from_on_prem_to_aws/vars/main.yml

Was this file intended to be checked in? These values seem very specific to a local testing environment.

Yes, it was intended to show some examples, but let me know if I have to remove it in case.

gravesm · 2023-09-20T17:53:34Z

playbooks/move_vm_from_on_prem_to_aws/move_vm_from_on_prem_to_aws.yml

+    - name: Import 'cloud.aws_ops.import_image_and_run_aws_instance' role
+      ansible.builtin.import_role:
+        name: cloud.aws_ops.import_image_and_run_aws_instance
+      vars:


It looks like there are some variables missing here. How does the user set the security groups, keypair, subnet, etc.?

I did not set those because they are optional, but if we want add all the variables that the role accepts I can do that.

playbooks/move_vm_from_on_prem_to_aws/README.md

gravesm · 2023-09-20T17:57:29Z

playbooks/move_vm_from_on_prem_to_aws/README.md

+* **keypair_name** (str): (Optional) The name of the SSH access key to assign to the EC2 instance. It must exist in the region the instance is created. If not set, your default AWS account keypair will be used.
+* **security_groups** (list): (Optional) A list of security group IDs or names to assiciate to the EC2 instance.
+* **vpc_subnet_id** (str): (Optional) The subnet ID in which to launch the EC2 instance instance (VPC). If none is provided, M(amazon.aws.ec2_instance) will chose the default zone of the default VPC.
+* **instance_volumes** (dict): (Optional) A dictionary of a block device mappings, by default this will always use the AMI root device so the **instance_volumes** option is primarily for adding more storage. A mapping contains the (optional) keys _device_name_, _ebs.volume_type_, _ebs.volume_size_, _ebs.kms_key_id_, _ebs.iops_, and _ebs.delete_on_termination_.


This would benefit from having the same structure as you use for the kvm_host var.

playbooks/move_vm_from_on_prem_to_aws/README.md

gravesm

One small thing, otherwise looks good.

playbooks/move_vm_from_on_prem_to_aws/README.md

roles/clone_on_prem_vm/README.md

roles/clone_on_prem_vm/tasks/main.yml

roles/import_image_and_run_aws_instance/README.md

roles/import_image_and_run_aws_instance/tasks/main.yml

abikouo · 2023-10-05T15:59:51Z

playbooks/move_vm_from_on_prem_to_aws/README.md

+    * **ansible_ssh_private_key_file** This variable specifies the path to the SSH private key file that Ansible should use for authentication when connecting to the host.
+    * **groups** This variable enabled you to assign the newly added host to one or more groups in the inventory.
+
+### Needed for the cloud.aws_ops.clone_on_prem_vm role


You should reference here the file roles/clone_on_prem_vm/REAME.md to avoid duplicate and for the playbook and role to be synced if there is an update on the role documentation

Done that. Let me know please if that works!

abikouo · 2023-10-05T16:00:01Z

playbooks/move_vm_from_on_prem_to_aws/README.md

+* **clone_on_prem_vm_overwrite** (bool): (Optional) Whether to overwrite or not an already existing on prem VM clone. Default: true.
+* **clone_on_prem_vm_local_image_path** (str): (Optional) The path where you would like to save the image. If the path does not exists on localhost, the role will create it. If this parameter is not set, the role will save the image in a _~/tmp_ folder.
+
+### Needed for the cloud.aws_ops.import_image_and_run_aws_instance role


same as above

abikouo · 2023-10-05T16:01:34Z

playbooks/move_vm_from_on_prem_to_aws/README.md

+
+## Playbook Variables
+
+* **kvm_host** (dict): Information about the host running the KVM hypervisr that are dynamically added to the inventory.


I would rather prefer having this describe into an inventory file that will be passed when running ansible playbook

Done that. Let me know please if that works!

abikouo · 2023-10-05T16:02:01Z

playbooks/move_vm_from_on_prem_to_aws/move_vm_from_on_prem_to_aws.yml

+      region: "{{ aws_region | default('us-east-1') }}"
+
+  tasks:
+    - name: Add host to inventory


would prefer to move this into an inventory file

abikouo · 2023-10-05T16:03:30Z

roles/clone_on_prem_vm/README.md

+          ansible_ssh_private_key_file: ~/.ssh/id_rsa.pub
+
+      tasks:
+        - name: Add host to inventory


same here, should be better to define this in an inventory and run the playbook on all hosts

hakbailey

Just a couple more small typos. otherwise this looks good!

playbooks/move_vm_from_on_prem_to_aws/README.md

GomathiselviS · 2023-10-18T16:22:20Z

roles/clone_on_prem_vm/README.md

+
+All the variables defined in section ``Playbook Variables`` can be defined inside the ``vars.yml`` file.
+
+Create a ``playbook.ym`` file like this:


Suggested change

Create a ``playbook.ym`` file like this:

Create a ``playbook.yml`` file like this:

GomathiselviS · 2023-10-18T16:22:40Z

roles/import_image_and_run_aws_instance/README.md

+
+All the variables defined in section ``Playbook Variables`` can be defined inside the ``vars.yml`` file.
+
+Create a ``playbook.ym`` file like this:


Suggested change

Create a ``playbook.ym`` file like this:

Create a ``playbook.yml`` file like this:

GomathiselviS · 2023-10-18T16:24:07Z

playbooks/move_vm_from_on_prem_to_aws/README.md

+      groups: mygroup
+```
+
+All the variables defined in section ``Playbook Variables`` can be defined inside the ``vars.yml`` file.


I apologize if I've missed it, but could you please point me to where the playbook variables section is located?

Here https://github.com/redhat-cop/cloud.aws_ops/pull/95/files#diff-3a382ac08ed4e75c0e95cbbabd59acfc9e5c8d543f4882cb588ee93f0ad0029fR10. To avoid content duplication I referenced the variable roles which are also the ones required by the playbook.

Signed-off-by: Alina Buzachis <[email protected]>

github-actions bot added the safe to test label Sep 12, 2023

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch 2 times, most recently from b6597d6 to 7fa9b60 Compare September 19, 2023 14:11

alinabuzachis changed the title ~~[WIP] Add move_vm_from_on_prem_to_aws role~~ Add move_vm_from_on_prem_to_aws role Sep 19, 2023

gravesm reviewed Sep 20, 2023

View reviewed changes

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch from f15ca51 to 948f1b8 Compare September 21, 2023 18:47

alinabuzachis changed the title ~~Add move_vm_from_on_prem_to_aws role~~ Add move_vm_from_on_prem_to_aws playbook and corresponding roles Sep 21, 2023

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch 5 times, most recently from 446a21c to 08fd92f Compare September 22, 2023 11:02

hakbailey reviewed Oct 2, 2023

View reviewed changes

playbooks/move_vm_from_on_prem_to_aws/README.md Outdated Show resolved Hide resolved

gravesm reviewed Oct 3, 2023

View reviewed changes

playbooks/move_vm_from_on_prem_to_aws/README.md Outdated Show resolved Hide resolved

hakbailey requested changes Oct 4, 2023

View reviewed changes

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch 2 times, most recently from 14afa21 to 72ef7a0 Compare October 5, 2023 14:31

alinabuzachis requested review from hakbailey and gravesm October 5, 2023 14:57

abikouo requested changes Oct 5, 2023

View reviewed changes

alinabuzachis requested a review from abikouo October 9, 2023 13:49

hakbailey requested changes Oct 10, 2023

View reviewed changes

playbooks/move_vm_from_on_prem_to_aws/README.md Outdated Show resolved Hide resolved

playbooks/move_vm_from_on_prem_to_aws/README.md Outdated Show resolved Hide resolved

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch from d3340ce to baa2a99 Compare October 10, 2023 14:20

hakbailey approved these changes Oct 11, 2023

View reviewed changes

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch from bfa24a5 to bd4088f Compare October 18, 2023 09:20

GomathiselviS reviewed Oct 18, 2023

View reviewed changes

GomathiselviS approved these changes Oct 18, 2023

View reviewed changes

Add move_vm_from_on_prem_to_aws role

e928a05

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis added 23 commits October 24, 2023 21:32

Rebase

42abee2

Signed-off-by: Alina Buzachis <[email protected]>

Linting

df4fd7e

Signed-off-by: Alina Buzachis <[email protected]>

Update galaxy.yml

bed1f84

Signed-off-by: Alina Buzachis <[email protected]>

Apply suggestions

3e55e8b

Signed-off-by: Alina Buzachis <[email protected]>

Fix typos

36d2216

Signed-off-by: Alina Buzachis <[email protected]>

Fix wording

b419c73

Signed-off-by: Alina Buzachis <[email protected]>

Update README.md

06fb898

Update README.md

323d0c9

Doc fixes

0245bb9

Signed-off-by: Alina Buzachis <[email protected]>

Update upon review

7a5eddd

Signed-off-by: Alina Buzachis <[email protected]>

Apply suggestions

6ce9958

Signed-off-by: Alina Buzachis <[email protected]>

Update main.yml

e46f8c6

Apply reveiw comments

57d40f0

Signed-off-by: Alina Buzachis <[email protected]>

Update move_vm_from_on_prem_to_aws.yml

b7112a8

Update move_vm_from_on_prem_to_aws.yml

adc7d30

Update move_vm_from_on_prem_to_aws.yml

09e68f6

Update move_vm_from_on_prem_to_aws.yml

db70365

Update README.md

4f34046

Update README.md

376986c

Update README.md

9c7f86d

Update README.md

8afe2fe

Update main.yml

ecb43f6

Revision after running on awx

fd9a487

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the move_vm_from_on_prem_to_aws branch from 73f8479 to fd9a487 Compare October 24, 2023 19:37

alinabuzachis added 2 commits October 24, 2023 21:38

Update README.md

584e607

Update README.md

1c39b43

alinabuzachis merged commit f24c6f3 into redhat-cop:main Oct 25, 2023
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add move_vm_from_on_prem_to_aws playbook and corresponding roles #95

Add move_vm_from_on_prem_to_aws playbook and corresponding roles #95

alinabuzachis commented Sep 12, 2023 •

edited

Loading

gravesm Sep 20, 2023

alinabuzachis Sep 21, 2023 •

edited

Loading

gravesm Sep 20, 2023

alinabuzachis Sep 21, 2023

gravesm Sep 20, 2023

gravesm left a comment

abikouo Oct 5, 2023

alinabuzachis Oct 9, 2023

abikouo Oct 5, 2023

abikouo Oct 5, 2023

alinabuzachis Oct 9, 2023

abikouo Oct 5, 2023

abikouo Oct 5, 2023

hakbailey left a comment

GomathiselviS Oct 18, 2023

GomathiselviS Oct 18, 2023

GomathiselviS Oct 18, 2023

alinabuzachis Oct 18, 2023


		## Playbook Variables

		* kvm_host (dict): Information about the host running the KVM hypervisr that are dynamically added to the inventory.


		All the variables defined in section ``Playbook Variables`` can be defined inside the ``vars.yml`` file.

		Create a ``playbook.ym`` file like this:

	Create a ``playbook.ym`` file like this:
	Create a ``playbook.yml`` file like this:

Add move_vm_from_on_prem_to_aws playbook and corresponding roles #95

Add move_vm_from_on_prem_to_aws playbook and corresponding roles #95

Conversation

alinabuzachis commented Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

alinabuzachis Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gravesm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hakbailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alinabuzachis commented Sep 12, 2023 •

edited

Loading

alinabuzachis Sep 21, 2023 •

edited

Loading