-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validaded repository from private automation hub in the controller #52
Add validaded repository from private automation hub in the controller #52
Conversation
Repos certified and validated were mixed up. Based on this page: https://console.redhat.com/ansible/automation-hub/token - certified or rh-certified -> published. - validated -> validated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add validated but we want to keep published
@djdanielsson thanks for responding. I think rh-certified and published is the same repository. You may have the same postgresql uniqueness constraint error I got when adding the a collection from two repositories. |
They are not the same, published is something that is uploaded locally like an internal collection |
oh I see @djdanielsson, thanks for the explanation. |
I thought it was the same as rh-certified while in fact it is a virtual repository created by default on automation hub for you to publish your own collection in your private AH.
if you wanted to test stuff in staging you could add it but I do not think it is commonly used so I do not want it to be in the template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small tweak and then we can merge it. I had done this in my personal copy but hadn't gotten to putting it back into the template so thanks for doing this
In a future release, the order will be taken into account
@djdanielsson thanks for the review! I didn't knew the order matters. I changed the order. |
Currently the order doesn't technically matter but hopefully in the future it does. In the UI it does matter but the module currently doesn't apply them strictly in the order they are given which is a feature that is requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Repositories
validated
was missing.Fix #51