Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validaded repository from private automation hub in the controller #52

Conversation

laurent-indermuehle
Copy link
Contributor

@laurent-indermuehle laurent-indermuehle commented Mar 20, 2024

Repositories validated was missing.
Fix #51

Repos certified and validated were mixed up. Based on this page:
https://console.redhat.com/ansible/automation-hub/token
- certified or rh-certified -> published.
- validated -> validated
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add validated but we want to keep published

@laurent-indermuehle
Copy link
Contributor Author

@djdanielsson thanks for responding.
May I ask more detail please?

I think rh-certified and published is the same repository. You may have the same postgresql uniqueness constraint error I got when adding the a collection from two repositories.

@djdanielsson
Copy link
Collaborator

They are not the same, published is something that is uploaded locally like an internal collection

@laurent-indermuehle
Copy link
Contributor Author

oh I see @djdanielsson, thanks for the explanation.
But then, do we need to add "staging" too?
image

I thought it was the same as rh-certified while in fact it is a
virtual repository created by default on automation hub for you to
publish your own collection in your private AH.
@laurent-indermuehle laurent-indermuehle changed the title fix automationhub's repository rh-certified and validated URLs Add validaded repository from private automation hub in the controller Mar 21, 2024
@djdanielsson
Copy link
Collaborator

if you wanted to test stuff in staging you could add it but I do not think it is commonly used so I do not want it to be in the template.

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small tweak and then we can merge it. I had done this in my personal copy but hadn't gotten to putting it back into the template so thanks for doing this

group_vars/all/organizations.yml Outdated Show resolved Hide resolved
In a future release, the order will be taken into account
@laurent-indermuehle
Copy link
Contributor Author

@djdanielsson thanks for the review! I didn't knew the order matters. I changed the order.

@djdanielsson
Copy link
Collaborator

Currently the order doesn't technically matter but hopefully in the future it does. In the UI it does matter but the module currently doesn't apply them strictly in the order they are given which is a feature that is requested

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 3c20471 into redhat-cop:main Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project sync fails when looking for collections declared in the requirements
2 participants