Fix order of roles to fix dependency over notifications (#44)

Notifications can be add to projects, job_templates and probably many others. To prevent failure we have to set them first.
redhat-cop · Jan 26, 2024 · 3ca613f · 3ca613f
1 parent 4f91e6b
commit 3ca613f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/playbooks/controller_config.yml b/playbooks/controller_config.yml
@@ -87,6 +87,11 @@
         name: infra.controller_configuration.organizations
       when: controller_organizations | length is not match('0')
 
+    - name: Include Notification role
+      ansible.builtin.include_role:
+        name: infra.controller_configuration.notification_templates
+      when: controller_notifications | length is not match('0')
+
     - name: Include projects role
       ansible.builtin.include_role:
         name: infra.controller_configuration.projects
@@ -136,11 +141,6 @@
         name: infra.controller_configuration.schedules
       when: controller_schedules | length is not match('0')
 
-    - name: Include Notification role
-      ansible.builtin.include_role:
-        name: infra.controller_configuration.notification_templates
-      when: controller_notifications | length is not match('0')
-
     - name: Include roles role
       ansible.builtin.include_role:
         name: infra.controller_configuration.roles

diff --git a/playbooks/install_configure.yml b/playbooks/install_configure.yml
@@ -162,6 +162,11 @@
         name: infra.controller_configuration.organizations
       when: controller_organizations | length is not match('0')
 
+    - name: Include Notification role
+      ansible.builtin.include_role:
+        name: infra.controller_configuration.notification_templates
+      when: controller_notifications | length is not match('0')
+
     - name: Include projects role
       ansible.builtin.include_role:
         name: infra.controller_configuration.projects
@@ -211,11 +216,6 @@
         name: infra.controller_configuration.schedules
       when: controller_schedules | length is not match('0')
 
-    - name: Include Notification role
-      ansible.builtin.include_role:
-        name: infra.controller_configuration.notification_templates
-      when: controller_notifications | length is not match('0')
-
     - name: Include roles role
       ansible.builtin.include_role:
         name: infra.controller_configuration.roles