Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTONET-986: Support for our own results stream and unique identifiers #23

Merged

Conversation

ryandgoulding
Copy link
Contributor

This change does the following:

  1. Modifies the claim.schema.json to support a generic "identifier", composed
    of a "url" and "version".

  2. Modifies the claim.schema.json to support a generic "result", composed of
    the JUnit metadata that we are require, and in the format we desire.

  3. Modifies claim.schema.json to become more accepting to "configuration". The
    downstream patch here:

    https://github.com/test-network-function/test-network-function/commit/
    54b0ba6e82ef6e46efc8ccbf0f5de07de7936e2d#diff-
    a3d824da3c42420cd5cbb0a4a2c0e7b5bfddd819652788a0596d195dc6e31fa5

    started to use arrays instead of maps to represent config objects, which in
    turn violated the schema here. Since we no longer have expectations of a
    map here, I also removed the override in overrides.json.

  4. Changes "results" -> "rawResults". Puts our "pretty" results in "results".

  5. Regenerates the golang client based on the updated claim.schema.json.

  6. Adds a significant number of tests, and modifies old ones, to comply with
    the new schema.

As a note, it was decided to use the convention #/definitions/id due to limitations
of jsonschema Python validator listed here:

python-jsonschema/jsonschema#343

This is the building block for the downstream adoption of the schema changes,
and enhanced reporting capabilities.

Signed-off-by: Ryan Goulding [email protected]

This change does the following:
1) Modifies the claim.schema.json to support a generic "identifier", composed
   of a "url" and "version".
2) Modifies the claim.schema.json to support a generic "result", composed of
   the JUnit metadata that we are require, and in the format we desire.
3) Modifies claim.schema.json to become more accepting to "configuration".  The
   downstream patch here:

   https://github.com/test-network-function/test-network-function/commit/ \
   54b0ba6e82ef6e46efc8ccbf0f5de07de7936e2d#diff- \
   a3d824da3c42420cd5cbb0a4a2c0e7b5bfddd819652788a0596d195dc6e31fa5

   started to use arrays instead of maps to represent config objects, which in
   turn violated the schema here.  Since we no longer have expectations of a
   map here, I also removed the override in overrides.json.
4) Changes "results" -> "rawResults".  Puts our "pretty" results in "results".
5) Regenerates the golang client based on the updated claim.schema.json.
6) Adds a significant number of tests, and modifies old ones, to comply with
   the new schema.

This is the building block for the downstream adoption of the schema changes,
and enhanced reporting capabilities.

Signed-off-by: Ryan Goulding <[email protected]>
@ryandgoulding ryandgoulding merged commit 1b3e339 into redhat-best-practices-for-k8s:main May 25, 2021
@ryandgoulding ryandgoulding deleted the CTONET-986 branch May 25, 2021 20:36
@ryandgoulding
Copy link
Contributor Author

Will have folks review this after the fact. This will not alter our current offering, as the only downstream consumer is test-network-function, which would require a version bump to get here. This allows me to at least stage the downstream version bump and changes in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant