CTONET-986: Support for our own results stream and unique identifiers #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following:
Modifies the claim.schema.json to support a generic "identifier", composed
of a "url" and "version".
Modifies the claim.schema.json to support a generic "result", composed of
the JUnit metadata that we are require, and in the format we desire.
Modifies claim.schema.json to become more accepting to "configuration". The
downstream patch here:
https://github.com/test-network-function/test-network-function/commit/
54b0ba6e82ef6e46efc8ccbf0f5de07de7936e2d#diff-
a3d824da3c42420cd5cbb0a4a2c0e7b5bfddd819652788a0596d195dc6e31fa5
started to use arrays instead of maps to represent config objects, which in
turn violated the schema here. Since we no longer have expectations of a
map here, I also removed the override in overrides.json.
Changes "results" -> "rawResults". Puts our "pretty" results in "results".
Regenerates the golang client based on the updated claim.schema.json.
Adds a significant number of tests, and modifies old ones, to comply with
the new schema.
As a note, it was decided to use the convention
#/definitions/id
due to limitationsof jsonschema Python validator listed here:
python-jsonschema/jsonschema#343
This is the building block for the downstream adoption of the schema changes,
and enhanced reporting capabilities.
Signed-off-by: Ryan Goulding [email protected]