Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move pipelines and resolvers controller from leader election to state… #5036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move pipelines and resolvers controller from leader election to state… #5036

wants to merge 1 commit into from
+7 −3

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Dec 3, 2024

…fulsets

khrm
khrm reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2024
@enarha
Copy link
Contributor

enarha commented Dec 3, 2024

/approve

@enarha enarha added the approved label Dec 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enarha, jkhelil, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkhelil
Copy link
Contributor Author

jkhelil commented Dec 3, 2024

/test appstudio-e2e-tests

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

@jkhelil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests bf65a77 link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hugares
hugares reviewed Dec 3, 2024
View reviewed changes
components/pipeline-service/development/main-pipeline-service-configuration.yaml
@@ -1684,6 +1684,7 @@ spec:
kube-api-qps: 50
replicas: 2
threads-per-controller: 32
statefulset-ordinals: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests are failing waiting for pipeline service to be "synced" from ArgoCD stand point.

Waiting 10 seconds for application sync
pipeline-service-in-cluster-local                  OutOfSync   Healthy

@khrm
Copy link
Contributor

khrm commented Dec 4, 2024

/test appstudio-e2e-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugares hugares hugares left review comments

@khrm khrm khrm left review comments

@enarha enarha Awaiting requested review from enarha

@xinredhat xinredhat Awaiting requested review from xinredhat

At least 1 approving review is required to merge this pull request.

Assignees

@khrm khrm

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkhelil @enarha @khrm @hugares