-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React to v16.0.0 #965
Changes from 5 commits
a7443a0
0bcf2a7
8ddc813
9232e77
a19084f
518e044
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ | |
"redux": "^3.6.0" | ||
}, | ||
"peerDependencies": { | ||
"react": "~0.14.2 || ^15.1.0" | ||
"react": "~0.14.9 || ^15.3.0 || ^16.0.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are the older version numbers changing here? Lerna will only hoist if version strings match exactly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
}, | ||
"devDependencies": { | ||
"ava": "^0.17.0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"routesFile": "./routes.js" | ||
"routesFile": "./routes.js", | ||
"hot": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this version compatible with the older versions of React that are supported below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment below. Yes it is compatible, but we will lose client-side HMR because react-hot-loader now needs us to use
module.hot.accept
and rendering the component tree in our entrypoints rather than using the no longer supportedReactMount
.See step 2 here http://gaearon.github.io/react-hot-loader/getstarted/